[WIP] Use weak aliases for the allocator shim #142366
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
A-LLVM
|
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in coverage instrumentation. cc @Zalathar |
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
rust-bors bot
added a commit
that referenced
this pull request
Jun 11, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
|
@bors2 try cancel forgot to fix warnings.... @bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
|
Try build cancelled. Cancelled workflows: |
rust-bors bot
added a commit
that referenced
this pull request
Jun 11, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
rust-bors bot
added a commit
that referenced
this pull request
Jun 12, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
|
Some changes occurred in compiler/rustc_codegen_gcc |
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
rust-bors bot
added a commit
that referenced
this pull request
Jun 12, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
|
All test failures seem to involve LTO. I suspect that the |
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
|
So close... The exit code is STATUS_DLL_NOT_FOUND, no idea why stripping breaks things. |
|
☔ The latest upstream changes (presumably #142259) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3
force-pushed
the
aliases
branch
2 times, most recently
from
20703f1 to
3564f58
Compare
|
Cleaned up a bit. Let's see if it didn't regress anything. @bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 16, 2025
[WIP] Use weak aliases for the allocator shim
|
@bors2 try cancel |
|
Try build cancelled. Cancelled workflows: |
rust-bors bot
added a commit
that referenced
this pull request
Jun 16, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
rust-bors bot
added a commit
that referenced
this pull request
Jun 16, 2025
Use the .drectve section for exporting symbols from dlls on Windows While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used. Necessary for and extracted out of #142366. Thanks `@dpaoliello` for figuring out this weird quirk of link.exe! try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
rust-bors bot
added a commit
that referenced
this pull request
Jun 16, 2025
Use the .drectve section for exporting symbols from dlls on Windows While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used. Necessary for and extracted out of #142366. Thanks `@dpaoliello` for figuring out this weird quirk of link.exe! try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
rust-bors bot
added a commit
that referenced
this pull request
Jun 17, 2025
Use the .drectve section for exporting symbols from dlls on Windows While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used. Necessary for and extracted out of #142366. Thanks `@dpaoliello` for figuring out this weird quirk of link.exe! try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used.
|
Rebased on top of #142568 which should have fixed the last remaining MSVC issue. MinGW is still broken because of ld.bfd having broken weak symbol handling. @bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
rust-bors bot
added a commit
that referenced
this pull request
Jun 17, 2025
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
|
Actually, maybe #134522 is the better approach after all. It doesn't need an extra attribute for specifying the symbol aliasing and as it turns out weak definitions are implemented by LLVM as weak symbol aliases on Windows anyway. #142568 should fix that PR for MSVC too and for MinGW it has the same issue as this PR. @bors2 try cancel |
|
Try build cancelled. Cancelled workflows: |
bjorn3
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.